-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read include directories from .ocp-index #79
Conversation
|
Two remarks:
That's it, thanks a bunch! |
Agree, will do it later today. Thanks! |
I have polished the patch; each line of |
I think this is a nice feature but as a user I'm a bit annoyed that I have to maintain yet another config file with this random metadata. Would it be possible for ocp-index to simply read build folder directories from .merlin files? For example: This example also shows how widely useful this might be as there are already quite a few .merlin's out there. |
Oh, sorry @nojb, I had completely forgotten about this, wouldn't it have been for @rgrinberg's remark. He actually has quite a point, if all the information we might need is already available in .merlin files, adding a new file format is superfluous, and I'd be quite happy to re-use them, esp. as it's nicer on the users. The only downside I can see is that if a project has an out of sync or wrong .merlin, it would hurt ocp-index while the heuristics might have worked; but I don't think it's a worthwile concern. The good news is that @nojb's contribution would need very little changes to use .merlin files. |
Sure, sounds like a good idea! I will try to to take a look at this today and make the necessary changes. Thanks! |
Just a quick update: I looked at this but it is not so easy because .merlin files supports patterns. We could re-implement the merlin logic in ocp-index but it is not so nice. We could also ask the merlin people to release a tiny library to read .merlin files so that we could reuse that. |
Indeed, that may be more complicated than we first thought, and the code seems non trivial. Also, I didn't read the full spec, but I am not sure |
A shared .project format used across all of these editor/exploration tools would be very nice to have. One format would make it easy enough to create a tool or suite of tools to automatically extract the relevant details from an oasis/ocp-build/obuild/etc build configuration. |
I would be happy to provide a library for reading |
Should be this either updated or closed? |
We have since switched to |
See #76.
The behavior of
ocp-index
is left unchanged if no.ocp-index
file is found in the tree. If it is, then it used as project root and a list of include directories is read from it. A new flag--no-recursive
is added to complement this functionality.